- Notifications
You must be signed in to change notification settings - Fork5.7k
API 4.4 changes#1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
API 4.4 changes#1464
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Nukesor commentedAug 5, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
FYI: The 4.2 and 4.3 Changes are still not merged:#1418 |
Nukesor commentedAug 9, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Pls remove the |
Ah, overlooked that one. Thanks for the heads up :) |
Conflicts:telegram/chatmember.pytests/test_bot.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few notes
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This reverts commitc4538e5.
Uh oh!
There was an error while loading.Please reload this page.
Attempt to incorporate API 4.4 changes.
Stuff I'm not sure I handled it correctly:
de_json
methods (Chat
andChatPermission
)all_members_are_administrators
inChat
restrict_chat_members
inBot
MessageEntities
: I adjustedMessage._parse_html
andMessage._parse_markdown
to allow for this. However, this only allows something like_bold *within* italic_
and not*bold _overlapping* italic_
. The announcement is not every clear, if that is also allowed …Did I miss anything?