- Notifications
You must be signed in to change notification settings - Fork5.7k
Closed
Description
With v21.4 we've seen a first successfull application of the new automation introduced in#4364. However, while making the first release I've seen a few steps that can use improvement:
- the tag still needs to be created manually. Moreover, it's currently createdbefore the pypi release is there. If the pypi release fails and changes have to be made, the tag needs to be moved, which isnot ideal
- separation of test-pypi and pypi release are not working as I'd hoped: The tag-push currently also triggers the test-pypi release and since the compute-sigantures steps "needs" it, I have to manually approve/reject it before the signatures are created and the gh release is created
Even if it means some code duplication (which I'd originally tried to avoid by having everything in one workflow), I therefore will split the test-pypi and pypi flows in two separate workflows and set different triggers:
- manual for test-pypi
- for pypi either manual or maybe based on regex commit-message