- Notifications
You must be signed in to change notification settings - Fork5.7k
Closed
Description
Possible candidates to add to the Defaults concept:
tzinfo
We should use Defauts.tzinfo as default instead of UTC … That would mean:
- When a job is created without setting tzinfo explicitly, use Defaults.tzinfo
- When calling JobQueue._put() with a naive
when
, usewhen.replace(tzinfo=defaults.tzinfo)
This would basically not change the current set up, but just put it under the hood - Probably
Message.date
and all the friends should also usedefaults.tzinfo
, so basically everydatetime
instance occuring in the lib.
Arguments of Filters
- Filters.command: allow commandsanywhere in the text or not
- Filters.{user, chat}:allow_empty (only relevant afterAllow updating user_ids/usernames of a running filters.user #1757)
How to make it work: We would need to override those attributes ondispatcher.add_handler
somehow. that's pretty much the only time, the filters and the dispatcher can see each other …
Dice.emoji
- Only relevant afterApi 4.8 #1917. Also discussable, if this really is a good idea, as the emoji attribute of
Dice
is positional and not optional
ReplyKeyboardMarkup
resize_keyboard
one_time_keyboard
Redesign ofdefault_quote
Right now,default_quote
get's passed from getting updates through all objects, whose attributes have aMessage
attribute and is set as attribute inMessage
. But as theMessage.reply_*
methods only work with a bot anyway, we could just accessMessage.bot.defaults.default_quote
.
See#1965
Metadata
Metadata
Assignees
Labels
No labels