- Notifications
You must be signed in to change notification settings - Fork262
perf: improve git history processing for changelog generation#972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
codejedi365 merged 2 commits intopython-semantic-release:masterfromcodejedi365:perf/git-history-processingJul 6, 2024
Merged
perf: improve git history processing for changelog generation#972
codejedi365 merged 2 commits intopython-semantic-release:masterfromcodejedi365:perf/git-history-processingJul 6, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
012f1c8 to3c53bacCompareThis converts the double for-loop (`O(n^2)`) down to `O(n)` using alookup table to match the current commit with a known tag rather thaniterating through all the tags of the repository every time.
3c53bac to1029bbbCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Purpose
Rationale
Refactoring comparison data into a lookup datastructure allows for
O(1)time lookups rather thanO(n)searches on repositories with lots of tags.How I tested
Manually through the evaluation of logs, where many logs were not printed and it was noticable the number of iterations in the loops. I did not do a benchmark datapoint though.
How to verify
Run on PSR itself as it has enough tags to cause a slowdown and many irrelevant log entries.