From some of the changes you are adding here, I think ruff is not reading our configuration. Or if it is than your version of pre-commit does not match the ruff version in pyproject.toml. The reason I say this is that in the lint job it is running ruff but it hasn't been an issue lately. The... in the type definitions is one of the things that ruff has gone back and forth with. First it was on a new line and a few versions back I had to move it all to inline.

Let me make sure I have the right version - should have installed the one in the project config, but maybe there’s a discrepancy somewhere?

FWIW:

% ruff --versionruff 0.4.4

Maybe the updates in#957 will help? I notice that it's got the formatting one pinned back, though maybe now the two can be consolidated?

Either way, I think the more usual default of theruff pre-commit hook is to only operate on the changed files vs. all files as it's currently configured.

@codejedi365 see if you like this better - got rid of all the autoformatting. If these two don't make sense, also feel free to just close.

I agree it should operate on only the changed files