- Notifications
You must be signed in to change notification settings - Fork262
feat: extend gitlab to edit a previous release if exists#934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
codejedi365 merged 8 commits intopython-semantic-release:masterfromcodejedi365:feat/gitlab-release-updateMay 27, 2024
Merged
feat: extend gitlab to edit a previous release if exists#934
codejedi365 merged 8 commits intopython-semantic-release:masterfromcodejedi365:feat/gitlab-release-updateMay 27, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1e26de9 tocf9e5fdCompareb357def to111972eCompare111972e to2a8681cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Purpose
Rationale
Brings GitLab more in line with the features of GitHub to be able to edit a previous release's notes via the
changelogsubcommand.I also found that with the switch to using
example.comas the domain there were more errors in the test suite as I would receive a 404 that would cause testing to fail. Clearly this means we were actually touching the real gitlab so I mocked out those appropriately.How I tested
I tested manually with a project access token on my local machine with a gitlab project. I first ran the pipeline to create a release normally and then used
semantic-release changelog --post-to-release-tag v1.0.0to update the release notes with a new template.Closes:#727