- Notifications
You must be signed in to change notification settings - Fork262
fix: enable--print-last-released* when in detached head or non-release branch#926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
codejedi365 merged 2 commits intopython-semantic-release:masterfromcodejedi365:fix/branch-restriction-enforcementJul 6, 2024
Merged
fix: enable--print-last-released* when in detached head or non-release branch#926
codejedi365 merged 2 commits intopython-semantic-release:masterfromcodejedi365:fix/branch-restriction-enforcementJul 6, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
e08c104 to93f04e7Compare42a7cfc to9111990Compare--print when in detached head or non-release branch--print-last-released* when in detached head or non-release branch9111990 tod8e7851CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Purpose
version --print-last-releasedoutside of release branches #900Rationale
When using PSR to evaluate what the last released tag was, it is irrelevant to impose release branch restrictions on the usage as it doesn't matter what branch you are actually on.
--printand--print-tagare not included here as those determine the next version value and those do currently rely upon the release branch configuration.How I tested
Created test cases that evaluate non-release branch environments in regular or strict mode while using
--print-last-released,--print-last-released-tag. The tests also evaluated the same command when in a detached head state.