- Notifications
You must be signed in to change notification settings - Fork261
refactor: optimize & improve maintainability of GitHub Action definition#914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
codejedi365 merged 12 commits intopython-semantic-release:masterfromcodejedi365:refactor/ghaMay 6, 2024
Merged
refactor: optimize & improve maintainability of GitHub Action definition#914
codejedi365 merged 12 commits intopython-semantic-release:masterfromcodejedi365:refactor/ghaMay 6, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When using Debian Bullseye, it did not have a git version availablethat supported SSH key signing. SSH key signing was integrated ingit version 2.34 and the highest version for Bullseye was 2.30. Throughthe backports repository, a version greater than 2.34 was made availablebut now bumping to Debian Bookworm, the available version is 2.39 in thebase OS repository so no backports configuration required.
Updates the base container that runs the GitHub Action environment topython3.12 which enables users to specify and run build scripts thatare python3.12 specific as python3.12 is now the latest stable versionof python available and we were only providing `3.10`.Resolves:python-semantic-release#801
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Purpose
Optimize the Docker build and improve maintainability of the Docker GitHub Action
Rationale
In order to improve maintainability, I removed the additional defaults of the action and rely on the internal configuration defaults of the package instead.