- Notifications
You must be signed in to change notification settings - Fork261
build(deps-dev): update pytest requirement from ~=7.0 to ~=8.2#903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version.- [Release notes](https://github.com/pytest-dev/pytest/releases)- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)- [Commits](pytest-dev/pytest@7.0.0...8.2.0)---updated-dependencies:- dependency-name: pytest dependency-type: direct:production...Signed-off-by: dependabot[bot] <support@github.com>
pytest >= 8.0.0 is incompatible with pytest-lazy-fixture, will need some more extensive changes - seeTvoroG/pytest-lazy-fixture#65 |
Was just looking at this too 😞 |
Same here, did not understand the workaround and unfortunately no, I didn't look into this problem further. Thank you for the willingness though. Before I saw this project using lazy-fixture (that I didn't know existed) I believe the more expected way to implement this by pytest would be to have the fixture return a function. That way at the beginning of your test is when you call the function which ensures accurate order of operations within the test. The problem we faced is the fact that parameterization calculations take place first and we expect files to be written and a directory changed to for the repo_* fixtures which causes unintended problems. If you wrap it in lazy-fixture then it is not evaluated until the last second when the test is executed. This also allowed us to pass varied fixtures in as parameters to the test. But honestly until more PRs are closed out a large refactor of the testing will just cause a bunch of merge conflicts for all of us. I'm not concerned with it at this time, I have bigger fish to fry. |
Superseded by#987. |
Uh oh!
There was an error while loading.Please reload this page.
Updates the requirements onpytest to permit the latest version.
Release notes
Sourced frompytest's releases.
... (truncated)
Commits
6bd3f31Tweak changelog for 8.2.09b6219bPrepare release version 8.2.0835765cMerge pull request#12130 from bluetech/fixtures-inline7e7503cunittest: report class cleanup exceptions (#12250)882c4dafixtures: inlinefail_fixturefunc2e8fb9ffixtures: extract a_check_fixturedefmethodacf2971fixtures: inline_getnextfixturedefinto_get_active_fixturedef3c77aecfixtures: move "request" check earlyd217d68fixtures: inline_compute_fixture_value530be28fixtures: use early return in_get_active_fixturedefYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)