Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(gha)!: use composite action for semantic release (#692)#741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
bernardcooke53 wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromcomposite-github-action

Conversation

@bernardcooke53
Copy link
Contributor

No description provided.

eikowagenknecht reacted with thumbs up emoji
@bernardcooke53
Copy link
ContributorAuthor

@zckv I have moved the changes from#692 over here.

I'm thinking I want to add the following to this PR (based off of the breakage in the previous one):

  • Document additional requirements for workflows now that the action isn't Dockerized
    • e.g. add asetup-python step
  • Add a workflow to test the GitHub action on runners using each ofubuntu-latest,macos-latest andwindows-latest
    • I've been playing about with some usagehere which I think could be a starting point
  • The entrypointaction.sh will need to be re-worked to be cross-platform, because when I ran this onwindows-latest it fell over quite quickly - the easiest thing will probably be to just make it a Python script instead of shell.

Will make PRs against this branch for each of those, obviously no obligation but if you still want to work on the change would you mind doing the same please? That way it can all be merged at once 🙏

kaechele added a commit to kaechele/bonaparte that referenced this pull requestDec 29, 2023
Later versions revertedpython-semantic-release/python-semantic-release#692which breaks builds on Python projects requiring a newer interpreterthan 3.10, which their container uses.Should be fine to update afterpython-semantic-release/python-semantic-release#741is merged again.Signed-off-by: Felix Kaechele <felix@kaechele.ca>
@eikowagenknecht
Copy link

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

@codejedi365codejedi365 self-assigned thisMar 30, 2024
@codejedi365codejedi365 removed their assignmentMar 30, 2024
@codejedi365codejedi365 changed the titlefeat!(action): use composite action for semantic release (#692)feat(gha)!: use composite action for semantic release (#692)Mar 30, 2024
Resolves:#692Co-authored-by: Bernard Cooke <bernard-cooke@hotmail.com>
@codejedi365codejedi365 added the breakingIdentifies breaking change labelMay 5, 2024
@codejedi365
Copy link
Contributor

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

@eikowagenknecht, although this composite action has not been merged yet.#914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of3.11 &3.12.

eikowagenknecht reacted with thumbs up emoji

@codejedi365codejedi365 added the confirmedPrevent from becoming stale labelMay 6, 2024
@zckv
Copy link
Contributor

zckv commentedMay 6, 2024

Hello 👋

Wouldn't it be simpler to create a separate action repository ? This solution would avoid a "breaking" change on this project for something that is not related to the PSR python code.

@codejedi365
Copy link
Contributor

Wouldn't it be simpler to create a separate action repository ?

No, I don't believe so. It sounds nice up front but we would then have to keep both projects in sync. This action change would still be a breaking change which would then cause a version number drift of the version numbers of the project which likely confuses the configurations used and the users. This may not matter as the proper version is a set dependency in the action.

I plan to wrap it in with the next breaking change for the project. The release will have a full migration instructions and such with it. Maybe at the breaking change it's moved to another repository which doesn't change all that much besides the version it points to upon this repository update.

@eikowagenknecht
Copy link

@eikowagenknecht, although this composite action has not been merged yet.#914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of3.11 &3.12.

Thanks, working fine for 3.12 now.

codejedi365 reacted with thumbs up emoji

@github-actions
Copy link

It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR?

@github-actionsgithub-actionsbot added the needs-updateNeeds status update from maintainers labelJul 15, 2024
@codejedi365
Copy link
Contributor

No update at this time however it looks like we will have a number of changes forv10 and this will be included.

Significant migration docs will be needed and any additional changes this PR didn't have completed yet.

@github-actionsgithub-actionsbot removed the needs-updateNeeds status update from maintainers labelJul 21, 2024
@github-actions
Copy link

It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR?

@github-actionsgithub-actionsbot added the needs-updateNeeds status update from maintainers labelSep 19, 2024
@codejedi365
Copy link
Contributor

Haven't gotten back around to reviewing and integrating this yet for v10

@github-actionsgithub-actionsbot removed the needs-updateNeeds status update from maintainers labelSep 21, 2024
@github-actions
Copy link

It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR?

@github-actionsgithub-actionsbot added the needs-updateNeeds status update from maintainers labelNov 20, 2024
@codejedi365
Copy link
Contributor

Haven't had time to get back to this. Likely will be delayed until v11.

@github-actionsgithub-actionsbot removed the needs-updateNeeds status update from maintainers labelNov 21, 2024
@github-actions
Copy link

It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR?

@github-actionsgithub-actionsbot added the needs-updateNeeds status update from maintainers labelMar 23, 2025
@codejedi365
Copy link
Contributor

Still in backlog

@github-actionsgithub-actionsbot removed the needs-updateNeeds status update from maintainers labelApr 20, 2025
@github-actions
Copy link

It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR?

@github-actionsgithub-actionsbot added the needs-updateNeeds status update from maintainers labelJun 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breakingIdentifies breaking changeconfirmedPrevent from becoming staleneeds-updateNeeds status update from maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bernardcooke53@eikowagenknecht@codejedi365@zckv

[8]ページ先頭

©2009-2025 Movatter.jp