- Notifications
You must be signed in to change notification settings - Fork261
Feat/verify upstream before push#1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
codejedi365 wants to merge8 commits intopython-semantic-release:masterChoose a base branch fromcodejedi365:feat/verify-upstream-before-push
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+977 −48
Open
Changes fromall commits
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
98ebe5f test(cmd-version): add e2e tests to verify upstream version check bef…
Copilot5011c39 feat(cmd-version): adds upstream update check into workflow to preven…
Copilot475bf23 test(git-project): adds unit tests that evaluate all error cases of v…
Copilot38715bf test(fixtures): add `git.fetch()` mock fixture & remote reference branch
codejedi3659b8dc6c test(cmd-version): add mocking of git fetch to prevent errors from up…
codejedi365db25a27 docs(github-actions): removed verify upstream status step from exampl…
codejedi365aed31a6 docs(commands): add description of automated upstream version checkin…
codejedi3650c369c7 docs(uv-integration): remove verify upstream check from uv integratio…
codejedi365File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletionsdocs/api/commands.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
49 changes: 5 additions & 44 deletionsdocs/configuration/automatic-releases/github-actions.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -891,45 +891,6 @@ to the GitHub Release Assets as well. | ||
| run: | | ||
| git reset --hard ${{ github.sha }} | ||
| - name: Action | Semantic Version Release | ||
| id: release | ||
| # Adjust tag with desired version if applicable. | ||
| @@ -998,11 +959,6 @@ to the GitHub Release Assets as well. | ||
| one release job in the case if there are multiple pushes to ``main`` in a short period | ||
| of time. | ||
| .. warning:: | ||
| You must set ``fetch-depth`` to 0 when using ``actions/checkout@v4``, since | ||
| Python Semantic Release needs access to the full history to build a changelog | ||
| @@ -1018,6 +974,11 @@ to the GitHub Release Assets as well. | ||
| case, you will also need to pass the new token to ``actions/checkout`` (as | ||
| the ``token`` input) in order to gain push access. | ||
| .. note:: | ||
| As of $NEW_RELEASE_TAG, the verify upstream step is no longer required as it has been | ||
codejedi365 marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| integrated into PSR directly. If you are using an older version of PSR, you will need | ||
| to review the older documentation for that step. See Issue `#1201`_ for more details. | ||
| .. _#1201: https://github.com/python-semantic-release/python-semantic-release/issues/1201 | ||
| .. _concurrency: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idconcurrency | ||
1 change: 0 additions & 1 deletiondocs/configuration/configuration-guides/uv_integration.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
30 changes: 29 additions & 1 deletionsrc/semantic_release/cli/commands/version.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletionssrc/semantic_release/errors.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletionssrc/semantic_release/gitproject.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletionstests/e2e/cmd_version/bump_version/git_flow/test_repo_1_channel.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletionstests/e2e/cmd_version/bump_version/git_flow/test_repo_2_channels.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletionstests/e2e/cmd_version/bump_version/git_flow/test_repo_3_channels.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletionstests/e2e/cmd_version/bump_version/git_flow/test_repo_4_channels.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.