- Notifications
You must be signed in to change notification settings - Fork262
test(cmd-version): add fixture to reproduce issue with empty changelog#1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tests/fixtures/repos/trunk_based_dev/repo_w_feature_branch_and_release_in_default.pyShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
5f2547f tofa8e3e5CompareUh oh!
There was an error while loading.Please reload this page.
81d1e6d tod14dc21Comparecodejedi365 commentedJun 6, 2025
@dzmitrysliaptsou, I just want to say fantastic work. You are the first person to actually implement an E2E test for this project in a long time. Thank you for the effort. I have just a few comments and adjustments and we can get this in. While you have been doing that I have been revamping the release history algorithm to consolidate both it and the version determination algorithm along with a lot of performance caching. This should be a huge improvement. |
codejedi365 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See review comments, if you need help, let me know and I can fix it this weekend and get this merged.
eb6dda7 to1b8cf1eCompare1b8cf1e to99fcb3cCompareThis commit adds a repo fixture and the rebuild repo test case to handle the situationwhere a branch was started before a release but then a release occured and the developerused a merge from the default branch (rather than rebase).ref:python-semantic-release#1252
14782b5 to52be3d4Comparef2ffdc0 intopython-semantic-release:masterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Purpose
Provides a repo fixture to reproduce the problem described in#1252 (based onthis comment)
Rationale
Added a new repo following the examples in other fixtures.
Had to made one more addition:
simulate_change_commits_n_rtn_changelog_entry()fixture always worked with thefile_in_repo. For this specific flow it caused merge conflicts, because commit in the feature branch was made before default branch was merged into a feature branch. Made this parameter configurable.How did you test?
I ran the test and it failed with the expected error (empty
## v0.3.0 (2025-05-31)changelog entry)How to Verify
@pytest.mark.xfaildecorator on thetests/e2e/cmd_version/bump_version/trunk_based_dev/test_repo_w_feature_branch_and_release_in_default.pytest.pytest -vv --comprehensive tests/e2e/cmd_version/bump_version/trunk_based_dev/test_repo_w_feature_branch_and_release_in_default.pyPR Completion Checklist
Reviewed & followed theContributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow theConventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)