Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(cmd-version): add fixture to reproduce issue with empty changelog#1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dzmitrysliaptsou
Copy link
Contributor

@dzmitrysliaptsoudzmitrysliaptsou commentedMay 31, 2025
edited
Loading

Purpose

Provides a repo fixture to reproduce the problem described in#1252 (based onthis comment)

Rationale

Added a new repo following the examples in other fixtures.
Had to made one more addition:simulate_change_commits_n_rtn_changelog_entry() fixture always worked with thefile_in_repo. For this specific flow it caused merge conflicts, because commit in the feature branch was made before default branch was merged into a feature branch. Made this parameter configurable.

How did you test?

I ran the test and it failed with the expected error (empty## v0.3.0 (2025-05-31) changelog entry)

>           assert expected_md_changelog_content == actual_md_changelog_contentE           assert == failed. [pytest-clarity diff shown]E             E             LHS vs RHS shown belowE             E               # CHANGELOGE               E               <!-- version list -->E               E               ## v0.3.0 (2025-05-31)E             + E             + ### FeaturesE             + E             + - Add new feature in the feature branchE             +   E             ([`0000000`](https://example.com/example_owner/example_repo/commit/0000000000000E             000000000000000000000000000))E               E               E               ## v0.2.0 (2025-05-31)E               E               ### FeaturesE               E               - Add another featureE                 ([`0000000`](https://example.com/example_owner/example_repo/commit/000000000E             0000000000000000000000000000000))E               E               E               ## v0.1.0 (2025-05-31)E               E               - Initial ReleaseE

How to Verify

  1. Comment (or remove@pytest.mark.xfail decorator on thetests/e2e/cmd_version/bump_version/trunk_based_dev/test_repo_w_feature_branch_and_release_in_default.py test.
  2. runpytest -vv --comprehensive tests/e2e/cmd_version/bump_version/trunk_based_dev/test_repo_w_feature_branch_and_release_in_default.py

PR Completion Checklist

  • Reviewed & followed theContributor Guidelines

  • Changes Implemented & Validation pipeline succeeds

  • Commits follow theConventional Commits standard
    and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)

  • Appropriate Unit tests added/updated

  • Appropriate End-to-End tests added/updated

  • Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)

@dzmitrysliaptsoudzmitrysliaptsouforce-pushed thetest/add-fixtures-merge-to-feature-after-release branch 2 times, most recently from81d1e6d tod14dc21CompareMay 31, 2025 20:32
@codejedi365
Copy link
Contributor

@dzmitrysliaptsou, I just want to say fantastic work. You are the first person to actually implement an E2E test for this project in a long time. Thank you for the effort. I have just a few comments and adjustments and we can get this in. While you have been doing that I have been revamping the release history algorithm to consolidate both it and the version determination algorithm along with a lot of performance caching. This should be a huge improvement.

dzmitrysliaptsou reacted with heart emoji

Copy link
Contributor

@codejedi365codejedi365 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See review comments, if you need help, let me know and I can fix it this weekend and get this merged.

@dzmitrysliaptsoudzmitrysliaptsou changed the titletest(cmd-version): Add fixture to reproduce issue with empty changelogtest(cmd-version): add fixture to reproduce issue with empty changelogJun 6, 2025
@dzmitrysliaptsoudzmitrysliaptsouforce-pushed thetest/add-fixtures-merge-to-feature-after-release branch 3 times, most recently fromeb6dda7 to1b8cf1eCompareJune 6, 2025 07:36
@dzmitrysliaptsoudzmitrysliaptsouforce-pushed thetest/add-fixtures-merge-to-feature-after-release branch from1b8cf1e to99fcb3cCompareJune 16, 2025 18:56
This commit adds a repo fixture and the rebuild repo test case to handle the situationwhere a branch was started before a release but then a release occured and the developerused a merge from the default branch (rather than rebase).ref:python-semantic-release#1252
@codejedi365codejedi365force-pushed thetest/add-fixtures-merge-to-feature-after-release branch from14782b5 to52be3d4CompareJune 20, 2025 05:42
@codejedi365codejedi365 merged commitf2ffdc0 intopython-semantic-release:masterJun 20, 2025
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@codejedi365codejedi365codejedi365 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dzmitrysliaptsou@codejedi365

[8]ページ先頭

©2009-2025 Movatter.jp