- Notifications
You must be signed in to change notification settings - Fork262
feat(parser-angular): add scope filtering option to Angular commit pa…#1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
codejedi365 commentedMar 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is already solved in#1143, but thank you for putting in the time to provide a solution. |
Author
asaf commentedMar 15, 2025
Closing in favor of the monorepo parser introduced in#1143 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Ensure Scope Filtering is Enforced Correctly
Resolves#1215
Purpose
This PR ensures thatscope filtering logic is correctly applied when
allowed_scopesis configured inConventionalCommitParserOptions. Previously, commits without a scope were incorrectly bypassing the filtering, and commits with no allowed scopes defined were still being evaluated unnecessarily.Rationale
allowed_scopesis not defined, the filtering logic should be skipped entirely to maintain the existing behavior.allowed_scopesis defined, the commitmust have a valid scope that is explicitly allowed.allowed_scopesis configured.This change ensures a strict enforcement of scope filtering while keeping backwards compatibility when
allowed_scopesis not set.How did you test?
Added unit tests to verify:
allowed_scopesis enabled.allowed_scopesdefinition behave as they currently do.Ran the test suite and verified that existing functionality remains unchanged for users who do not configure scope filtering.
How to Verify
pytestto ensure all tests pass.ConventionalCommitParserwith different configurations:allowed_scopes: Behavior remains unchanged.allowed_scopesdefined: Only commits with matching scopes should be allowed.allowed_scopesis defined.PR Completion Checklist
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)