- Notifications
You must be signed in to change notification settings - Fork262
build(deps-dev): update dev dependencies and pre-commit hooks#1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3e647dd to55848d3Compare9942ac6 tob2ef1fbComparewyardley commentedAug 28, 2024
@codejedi365 not time-sensitive, but does this one look reasonable to you? |
- Update ruff to v0.6.3- Update mypy to v1.11.2- Update some pre-commit hooks
codejedi365 commentedAug 29, 2024
Hey@wyardley, sorry for the delay, had a lot of changes in my life recently and have not had much time over the past month. The changes look fine. It's just lower on the priority as it's dev env stuff and I've been wanting to sit down and review the changelogs of the dependencies before introduction. In the grand scheme of things, I would rather that each dependency is bumped in their own commits so that they are distinguishable in the git history in case one causes unforeseen issues. I also already have the dependabot PRs open and would rather add the "pre-commit" update commit added to those branches. So they are in sync. Does that make sense? Note you can open PRs against other branches not just master. One hesitancy I have with the constant update of ruff is that it's still not above a I would appreciate it if you desire to make more contributions to more to start tackling some of those "good first issue" tagged issues as I'm really trying to knock down the ticket queue below 70! |
wyardley commentedAug 29, 2024
Yes, it’s remembering to bump them in sync in pre-commit that’s a pain but that totally makes sense (renovate can do it fwiw) I think ruff should error in CI now if there are breaking changes that affect the existing code. and sounds good. |
codejedi365 commentedAug 30, 2024
It's a pain but I don't really forget that stuff. I've looked into renovate and looks good but have not implemented it yet.
That's why I have locked in the specific version of ruff (Andy mypy). I don't want an arbitrary bump in version because of flexible pip resolution to cause failures in CI that were not a problem in a previous run. |
Uh oh!
There was an error while loading.Please reload this page.
Purpose
Looked at updating
pre-commititself in dev dependencies, however, looks like Python 3.8 (which checks still run on) doesn't support anything after ~ 3.5.#1009 and#1006 would likely auto-close after this.
Rationale
How did you test?
How to Verify