- Notifications
You must be signed in to change notification settings - Fork75
Add numpy 2.0 compatibility#235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
So my fix, fixes old numpy but breaks new. Let me try again. |
@apdavison, both pre and post NumPy 2.0 tests are now passing on this PR. |
axelande commentedAug 21, 2024
Any plans of including this PR and release a new version that is compatible with numpy2? |
yes, I'm hoping to merge this and make a release during the coming week. |
bb96cbb intopython-quantities:master 44 checks passed
Uh oh!
There was an error while loading.Please reload this page.
JakobKai added a commit to JakobKai/python-quantities that referenced this pull requestMay 13, 2025
`quantities.Quantity.deepcopy` assumed that new objects copy the dataper defualt. This is no longer true since the adaptation to numpy 2(python-quantities#235, commit:ed43021).
JakobKai added a commit to JakobKai/python-quantities that referenced this pull requestMay 13, 2025
`quantities.Quantity.deepcopy` assumed that new objects copy the dataper defualt. This is no longer true since the adaptation to numpy 2(python-quantities#235, commit:ed43021).
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is built off of#232
Since I don't know array wrapping perfectly I may need to tweak this again.