- Notifications
You must be signed in to change notification settings - Fork1.3k
Feature: Add support for .dotx Word templates (#1532)#1537
Open
coderamaster wants to merge 1 commit intopython-openxml:masterfrom
Open
Feature: Add support for .dotx Word templates (#1532)#1537coderamaster wants to merge 1 commit intopython-openxml:masterfrom
coderamaster wants to merge 1 commit intopython-openxml:masterfrom
Conversation
- Added WML_TEMPLATE_MAIN content type constant- Updated Document() to accept both .docx and .dotx files- Added part factory mapping for template content type- Added tests for .dotx template loading-Fixespython-openxml#1532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#1532.
Adds support for loading Word template files (
.dotx) withpython-docx.Document().Problem
Loading a
.dotxfile currently raises aValueErrordue to an unsupported content type. Even if bypassed, the part factory creates a genericPartinstead ofDocumentPart, causing anAttributeError.Solution
Treat
.dotxtemplates the same as.docxdocuments, which matches the OOXML spec.Changes:
DocumentPart.dotxloadingTesting
.dotxfiles.docxbehavior remains unchanged