- Notifications
You must be signed in to change notification settings - Fork1.3k
Fix: Replace deprecated delimitedList with DelimitedList#1536
Open
coderamaster wants to merge 1 commit intopython-openxml:masterfrom
Open
Fix: Replace deprecated delimitedList with DelimitedList#1536coderamaster wants to merge 1 commit intopython-openxml:masterfrom
coderamaster wants to merge 1 commit intopython-openxml:masterfrom
Conversation
- Updated import to use DelimitedList instead of delimitedList- Replaced delimitedList() calls with DelimitedList() in grammar()- Fixes pyparsing deprecation warning in test utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed deprecation warning in test utilities by replacing
delimitedListwithDelimitedList.Problem
The test utilities use
delimitedListfrom pyparsing, which is deprecated in newer versions. This causes deprecation warnings when running tests:Solution
tests/unitutil/cxml.pyto useDelimitedListinstead ofdelimitedList.delimitedList()withDelimitedList()in the grammar function.Changes Made
delimitedList(attr_def)withDelimitedList(attr_def)(line 246).delimitedList(node)withDelimitedList(node)(line 263).Testing
Checklist