- Notifications
You must be signed in to change notification settings - Fork1.3k
feat: Add banded columns/rows attributes to table#1524
Open
mansenfranzen wants to merge 1 commit intopython-openxml:masterfrom
Open
feat: Add banded columns/rows attributes to table#1524mansenfranzen wants to merge 1 commit intopython-openxml:masterfrom
mansenfranzen wants to merge 1 commit intopython-openxml:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting banded columns and rows. It adds
CT_TblLookas a new OxmlElement and maps it toTable's newbanded_columnsandbanded_rowsproperties.I'm somewhat unsure regarding the property names
banded_columnsandbanded_rowsbecause they should indicate a boolean. However,autofitis also a boolean which follows the same naming convention.I tested the changes locally by inspecting both XML and rendered output in word. However, little guidance regarding proper tests would be much appreciated.
By the way - thanks for this library!