Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350)#1518

Open
TommasoPetrolito wants to merge 1 commit intopython-openxml:masterfrom
TommasoPetrolito:fix_external_references
Open

Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350)#1518
TommasoPetrolito wants to merge 1 commit intopython-openxml:masterfrom
TommasoPetrolito:fix_external_references

Conversation

@TommasoPetrolito
Copy link

@TommasoPetrolitoTommasoPetrolito commentedSep 10, 2025
edited
Loading

I start from this issue/PR:
#1350
Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged.
In many projects I had to use the custom commits on forks to make it work, the discussion/conversation in PR 1350 shows that the issue is felt by a significant number of users and it would be nice to have this very little change finally merged@scanny

THE MODIFICATION IS:

The added code checks if self.target_ref exists and if it starts with a "#", which is a common way to denote external references. If both conditions are met, the method returns RTM.EXTERNAL, indicating that the target reference is external.

This change improves the robustness of our code by correctly handling and classifying external references. This will prevent potential errors or unexpected behavior when encountering such references.

Please merge this change now that the modification is properly aligned with latest code version and has no conflicts.

@TommasoPetrolito
Copy link
Author

@scanny any news about this?

@TommasoPetrolito
Copy link
Author

@scanny please can this be merged?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TommasoPetrolito

[8]ページ先頭

©2009-2026 Movatter.jp