- Notifications
You must be signed in to change notification settings - Fork1.2k
Update Table Style Example in the Quickstart Guide#1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
lb803 wants to merge2 commits intopython-openxml:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Update Table Style Example in the Quickstart Guide#1371
lb803 wants to merge2 commits intopython-openxml:developfromlb803:chore_update_table_style_quickstart
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4762810 to0a8e9c4CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the table style example offered in the quickstart guide.
Currently, the quickstart guide reports an example to style tables which probably refers to an older version of python-docx. Using this example in a project running the latest version of the library (1.1.0) leads to a deprecation message "UserWarning: style lookup by style_id is deprecated. Use style name as key instead."
The API documentation reportsthe up-to-date convention to style tables (TL;NR the table style name allows spaces but not hyphens). This PR updates the example and its description to match the new convention.