Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork70
Update pre-commit hooks#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kurtmckee wants to merge11 commits intopython-openapi:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was fixed mechanically using the following command:```pre-commit migrate-config```
This was updated mechanically using the following command:```pre-commit autoupdate```
`pyupgrade` upgrades `%` and `.format()` usage to f-strings.
Additionally, add a configuration for flake8.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR introduces the following changes:
Fix deprecated pre-commit stage names.
When
pre-commit installis run, it currently throws a deprecation regarding the stage names in the config file. This is now fixed.Update the
pyupgradehook to its latest version, and update its target syntax version to Python 3.9+.Remove
flyntas a pre-commit hook.Its functionality is handled by the
pyupgradehook.Migrate from
localpre-commit hooks to standard, hosted pre-commit hooks.This change is necessary because not all git-related tooling runs pre-commit hooks with the same activated virtual environment that the Poetry dev dependencies are installed in.
Taken together, these changes bring the pre-commit hook configuration up-to-date, and make it possible to enablepre-commit.ci for the repo if you choose to do so (and I highly recommend doing so!).
Note
I've split the commits up so that it can be reviewed commit-by-commit. This isolates the manual and automatic changes so that they can be reviewed in smaller chunks.