python-openapi/openapi-spec-validatorPublic

NotificationsYou must be signed in to change notification settings
Fork70
Star358

fix: check duplicates schemas when loading swagger#157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Marwen94 wants to merge1 commit intopython-openapi:master

base:master

Choose a base branch

fromMarwen94:check_duplicates_schemas_defs_when_loading_swagger

Open

fix: check duplicates schemas when loading swagger#157

Marwen94 wants to merge1 commit intopython-openapi:masterfromMarwen94:check_duplicates_schemas_defs_when_loading_swagger

Conversation

Copy link

Marwen94 commentedJun 22, 2022

Closes#156

fix: check duplicates schemas when loading swagger

45dd535

Copy link

codecovbot commentedJun 24, 2022•
edited
Loading

Codecov Report

Merging#157 (45dd535) intomaster (a29b4f9) willincrease coverage by0.12%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master     #157      +/-   ##==========================================+ Coverage   95.97%   96.09%   +0.12%==========================================  Files          18       18                Lines         547      564      +17       Branches      103      109       +6     ==========================================+ Hits          525      542      +17  Misses         12       12                Partials       10       10

Impacted Files	Coverage Δ
openapi_spec_validator/handlers/compat.py	`90.90% <100.00%> (+30.90%)`	⬆️
openapi_spec_validator/handlers/file.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea29b4f9...45dd535. Read thecomment docs.

Copy link

Author

Marwen94 commentedJun 29, 2022

@p1c2u could you please have a look at this PR ?

Copy link

Collaborator

p1c2u commentedJun 30, 2022

Looks good. Just wondering how this affects the performance.

Copy link

Author

Marwen94 commentedJun 30, 2022

Looks good. Just wondering how this affects the performance.

I don't think this influences a lot the performance since it only adds an o(n) complexity wheren is the number of schema in a given swagger. Imhon in a real world context is in [1, 100].

We can set the duplicate check optional also, what do you think ?

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: check duplicates schemas when loading swagger#157

Are you sure you want to change the base?

fix: check duplicates schemas when loading swagger#157

Uh oh!