Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33
improve logging in shortcuts.py and turn to pytest in test_shortcut.py#219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
improve logging in shortcuts.py and turn to pytest in test_shortcut.py#219
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedMar 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #219 +/- ##==========================================- Coverage 84.38% 83.04% -1.35%========================================== Files 6 6 Lines 237 230 -7 Branches 48 47 -1 ==========================================- Hits 200 191 -9- Misses 24 26 +2 Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| from typing import Any | ||
| from typing import Hashable | ||
| from typing import Mapping | ||
| from typing import Type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would keep it as it is here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Returned it back
| if errors: | ||
| error = best_match(errors) | ||
| error.message = f"Validation failed: {error.message}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be nice to have it tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I studied a little more on my work project.
The solution I proposed adds another line to the log, although it's already clear from the output what's going on.
Returned the logic as it was before my edits.
Hi
I've been using this project for my autotests for a very long time and I want to make a small contribution.
In this CC, the following was done:
Additionally done:
I will be glad to receive feedback.