Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refuse to cast str or bytes to array#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
p1c2u merged 1 commit intopython-openapi:masterfromandersk:array-cast
Sep 13, 2022

Conversation

andersk
Copy link
Contributor

Althoughstr andbytes act as sequences in Python, they do not count as arrays according to OpenAPI, so we should not allow them to validate as arrays.

@codecov
Copy link

codecovbot commentedSep 13, 2022
edited
Loading

Codecov Report

Merging#421 (7be7fcc) intomaster (692f2c6) willincrease coverage by0.00%.
The diff coverage is100.00%.

❗ Current head7be7fcc differs from pull request most recent head1aece83. Consider uploading reports for the commit1aece83 to get more accurate results

@@           Coverage Diff           @@##           master     #421   +/-   ##=======================================  Coverage   93.38%   93.39%           =======================================  Files          97       97             Lines        2344     2346    +2       Branches      292      293    +1     =======================================+ Hits         2189     2191    +2  Misses        120      120             Partials       35       35
Impacted FilesCoverage Δ
openapi_core/casting/schemas/casters.py93.33% <100.00%> (+0.31%)⬆️
openapi_core/casting/schemas/exceptions.py100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

@p1c2up1c2uforce-pushed thearray-cast branch 2 times, most recently from7be7fcc toa8c3729CompareSeptember 13, 2022 10:05
Although str and bytes act as sequences in Python, they do not countas arrays according to OpenAPI, so we should not allow them tovalidate as arrays.Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@p1c2u
Copy link
Collaborator

@andersk thank you for the contribution.

@p1c2up1c2u merged commit5553fe4 intopython-openapi:masterSep 13, 2022
@anderskandersk deleted the array-cast branchSeptember 13, 2022 10:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@p1c2up1c2up1c2u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@andersk@p1c2u

[8]ページ先頭

©2009-2025 Movatter.jp