Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove pythonDot highlight match#927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
diraol merged 2 commits intopython-mode:developfromzhimsel:dot_hi_fix
Feb 19, 2019

Conversation

zhimsel
Copy link
Contributor

@zhimselzhimsel commentedJul 27, 2018
edited by diraol
Loading

When thecursorcolumn orcursorline vim option is set,any. characters result in the highlighting being set toNormal (instead of blank). This means that the "highlighted" line (viacursorline) is broken over the period. Please see attached screenshot for an example:

screen shot 2018-07-27 at 14 10 06

As far as I can tell, thepythonDot match doesn't really do anything except drop the highlighting back toNormal in apythonDottedName match. This just seems useless, so I think we should just remove it and let the dots have the same highlight as the rest of thepythonDottedName matches.

The main reason for this PR was not for a specific issue (my highlighting issue was just a symptom). I submitted this PR because I noticed that thepythonDot highlight group seemed entirely pointless. All it does is drop the highlighting for any. characters toNormal. This doesn't seem to be expected or desired behavior (the. should match the surrounding highlight).

This confuses the 'cursorline' and 'cursorcolumn' vim options
zhimsel added a commit to zhimsel/dotfiles that referenced this pull requestJul 27, 2018
@diraol
Copy link
Contributor

diraol commentedJan 6, 2019
edited
Loading

@zhimsel sorry not giving a feedback before.

I've tested over here in a clean environment, and I was not able to reproduce the behavior you described. I mean, I've tested with onlypython-mode andvim-colorschemes plugins and the highlight worked as expected.

Are you sure that there isn't any other plugins/configs interacting in your environment? Which theme are you using? solarized-dark?

@zhimsel
Copy link
ContributorAuthor

Are you sure that there isn't any other plugins/configs interacting in your environment?

It's quite possible. I can do some reductive testing to see if any other plugins are interfering when I get the time. I'll report back here once I've had the chance.

Which theme are you using? solarized-dark?

Yes, solarized-dark.

@diraol
Copy link
Contributor

Thanks@zhimsel !
I'm using a docker-environment to test python-mode. You can give it a try to start from a cleaner env without messing up with your own.
You can find more info about it here:
#977

@zhimsel
Copy link
ContributorAuthor

@diraol I was able to do some more verification of this issue.

Using the following vimrc with neovim0.3.4:

source~/.vim/vim-plug/plug.vim" managed externallycallplug#begin('~/.vim/plugins')  Plug'altercation/vim-colors-solarized'  Plug'~/dev/python-mode',callplug#end()" Set color schemesilent!colorscheme solarizedsetcursorline" Highlight current linesyntaxenable" Enable syntax highlighting" show highlight group for what's under the cursormap<F10>:echo "hi<" . synIDattr(synID(line("."),col("."),1),"name") . '> trans<'\ . synIDattr(synID(line("."),col("."),0),"name") . "> lo<"\ . synIDattr(synIDtrans(synID(line("."),col("."),1)),"name") . ">"<CR>

I confirmed that the. is de-highlighted in the current line withcursorline set. I also tested theflazz/vim-colorscheme version of solarized.


The main reason for this PR was not for a specific issue (my highlighting issue was just a symptom). I submitted this PR because I noticed that thepythonDot highlight group seemed entirely pointless. All it does is drop the highlighting for any. characters toNormal. This doesn't seem to be expected or desired behavior (the. should match the surrounding highlight).

@diraol
Copy link
Contributor

Hum... got it!

Well, I could not reproduce it, not even with your suggestion under a clean env (dockerized).

But the proposed changes seems to be reasonable after all (now that you explained the reason behind it).
So I'll merge and if someone faces issues with it, a new issue can be opened, and we can discuss it better. =) Thanks for the contribution!

@diraoldiraol merged commit81a4f6e intopython-mode:developFeb 19, 2019
@zhimsel
Copy link
ContributorAuthor

No problem! Thanks for merging!

@zhimselzhimsel deleted the dot_hi_fix branchFebruary 19, 2019 21:17
zhimsel added a commit to zhimsel/dotfiles that referenced this pull requestFeb 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zhimsel@diraol

[8]ページ先頭

©2009-2025 Movatter.jp