Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork770
Fix #826#868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix #826#868
Uh oh!
There was an error while loading.Please reload this page.
Conversation
diraol commentedMar 27, 2018
Hi@jennaliu thanks for your contribution! Can you provide any kind of example in which the previous version fails but it works with the newer code? |
jennaliu commentedMar 27, 2018
When opening a file with class or function definitions at the beginning of the file, Vim freezes. To test it, create a file with the following content (no empty lines at the beginning of the file), and open it with Vim. Sorry, I am not very familiar with the test suite right now. I submitted this pull request because it fixed my issue and I thought it could also help others. classClass1:def__init__(self):super().__init__()classClass2:def__init__(self):super().__init__() |
diraol commentedMar 27, 2018
Don't worry@jennaliu !! |
fmv1992 commentedMar 28, 2018
Thank you and thanks@diraol for your steady collaboration! |
previous_definition could reach the first line during the loop. Simply checking it before entering the loop is not enough.