NotificationsYou must be signed in to change notification settings
Fork773
Star5.5k

Modify loclist to separate errors from warnings#798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

bixycler wants to merge1 commit intopython-mode:developfrombixycler:develop

Closed

Modify loclist to separate errors from warnings#798

bixycler wants to merge1 commit intopython-mode:developfrombixycler:develop

Conversation

Copy link

Contributor

bixycler commentedOct 6, 2017

Separate errors from warnings (errors are shown above warnings)
[g:pymode_lint_cwindow] open loclist only if there is at least one error (not warnings)
[g:pymode_lint_cwindow] jump to first error

Changes to be committed:
modified: autoload/pymode/lint.vim
modified: autoload/pymode/tools/loclist.vim
modified: autoload/pymode/tools/signs.vim
modified: pymode/rope.py

Modify loclist

868103a

- Separate errors from warnings (errors are shown above warnings)- [g:pymode_lint_cwindow] open loclist only if there is at least one error (not warnings)- [g:pymode_lint_cwindow] jump to first errorChanges to be committed:modified:   autoload/pymode/lint.vimmodified:   autoload/pymode/tools/loclist.vimmodified:   autoload/pymode/tools/signs.vimmodified:   pymode/rope.py

bixycler changed the title~~Modify loclist~~Modify loclist to separate errors from warnings

Nov 15, 2017

fmv1992 force-pushed thedevelop branch 4 times, most recently from3f4fc36 to60c638dCompare

November 22, 2017 02:23

Copy link

Contributor

diraol commentedFeb 14, 2018

I like a lot the idea of this PR!@bixycler can you rebase it against our develop branch to solve the conflict and see if it passes on tests?

@fmv1992 what do you think about this PR?

Copy link

Contributor

fmv1992 commentedFeb 14, 2018

I thought pymode was already like that in the past (show errors first then warnings).

I think we should open the loclist if it is not empty (that is, even if its only warnings they should be opened). The rationale behind this is that users can already pinpoint-ignore what they don't regard as warnings.

So I bet that one could already achieve this feat with:

Skip errors and warnings                                 *'g:pymode_lint_ignore'*E.g. ["W", "E2"] (Skip all Warnings and the Errors starting with E2) etc.>    let g:pymode_lint_ignore = ["E501", "W",]

(from the docs)