Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork772
dont raise an exception when Logger has no message handler#139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
2 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletionpylibs/ropemode/decorators.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Empty file addedpylibs/ropemode/tests/__init__.py
Empty file.
48 changes: 48 additions & 0 deletionspylibs/ropemode/tests/decorators_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/usr/bin/env python | ||
| import os | ||
| import sys | ||
| sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..")) | ||
| import unittest | ||
| from ropemode.decorators import Logger | ||
| class LoggerTests(unittest.TestCase): | ||
| def test_Logger_called_with_no_args_doesnt_raise_TypeError(self): | ||
| """ | ||
| When not initialized with a message display method, Logger | ||
| prints the message to stdout without raising an exception. | ||
| """ | ||
| logger = Logger() | ||
| try: | ||
| logger("a message") | ||
| except TypeError: | ||
| self.fail("logger raised TypeError unexpectedly") | ||
| class LoggerMessageHandlerTests(unittest.TestCase): | ||
| def setUp(self): | ||
| self.message = "" | ||
| self.logger = Logger() | ||
| self.logger.message = self._echo | ||
| def _echo(self, message): | ||
| self.message += message | ||
| def test_message_handler_with_no_short_message(self): | ||
| """Test that message handler is called""" | ||
| self.logger("a message") | ||
| self.assertEqual(self.message, "a message") | ||
| def test_only_short_True(self): | ||
| """Test that only_short=True prints only the short message""" | ||
| self.logger.only_short = True | ||
| self.logger("a long message", "a short message") | ||
| self.assertEqual(self.message, "a short message") | ||
| def test_only_short_False(self): | ||
| """Test that only_short=False prints both messages""" | ||
| self.logger.only_short = False | ||
| self.logger("a long message", "a short message") | ||
| self.assertEqual(self.message, "a long messagea short message") |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.