Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork773
Bump dependencies#1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Bump dependencies#1170
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f044986
to72568d6
CompareHey folks, I need some help here, there is an error happening on the tests but I couldn't figure out how to solve it. Any help here is very welcome! |
@lieryan wanna help here? |
lieryan commentedJun 28, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I was looking into this, and I think I found the issue. On current develop, when running
but using the updated version in the PR, the
the format of how this options has been parsed has changed a bit, but that is not the issue. The issue is that linters list no longer have A quick fix for the test is to do something like: diff --git a/pymode/lint.py b/pymode/lint.pyindex c530404..56208a6 100644--- a/pymode/lint.py+++ b/pymode/lint.py@@ -42,6 +42,10 @@ def code_check(): raise ValueError('g:pymode_lint_select should have a list type') else: select = env.var('g:pymode_lint_select')+ if 'pep8' in linters:+ ## maybe add user-visible deprecation warning here+ linters.remove('pep8')+ linters.append('pycodestyle') options = parse_options( linters=linters, force=1, ignore=ignore, this would make the test passes, but it would break the |
Uh oh!
There was an error while loading.Please reload this page.
Updating our submodules and trying to fix the errors that are showing up.
Also improve the shell scripts tests by linting the files and improving the visual output.