Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump dependencies#1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
diraol merged 11 commits intodevelopfromdro/bump_dependencies
Jul 3, 2023
Merged

Bump dependencies#1170

diraol merged 11 commits intodevelopfromdro/bump_dependencies
Jul 3, 2023

Conversation

diraol
Copy link
Contributor

@diraoldiraol commentedJun 24, 2023
edited
Loading

Updating our submodules and trying to fix the errors that are showing up.

Also improve the shell scripts tests by linting the files and improving the visual output.

@diraoldiraolforce-pushed thedro/bump_dependencies branch 2 times, most recently fromf044986 to72568d6CompareJune 24, 2023 05:16
@diraoldiraolforce-pushed thedro/bump_dependencies branch from72568d6 toa4731b4CompareJune 24, 2023 18:56
@diraol
Copy link
ContributorAuthor

Hey folks, I need some help here, there is an error happening on the tests but I couldn't figure out how to solve it.

Any help here is very welcome!

@diraol
Copy link
ContributorAuthor

@lieryan wanna help here?

lieryan reacted with eyes emoji

@lieryan
Copy link
Contributor

lieryan commentedJun 28, 2023
edited
Loading

I was looking into this, and I think I found the issue.

On current develop, when runningpylama, the pylamaoptions looks like this:

Namespace(    ...    linters=[        ('pyflakes', <pylama.lint.pylama_pyflakes.Linter object at 0x7f088d4120b0>),        ('pep8', <pylama.lint.pylama_pycodestyle.Linter object at 0x7f088d412890>),        ('mccabe', <pylama.lint.pylama_mccabe.Linter object at 0x7f088d412410>),    ],    ...)

but using the updated version in the PR, theoptions looks like this:

Namespace(    ...    linters=[        'pyflakes',        'mccabe',    ],    ...)

the format of how this options has been parsed has changed a bit, but that is not the issue. The issue is that linters list no longer havepep8 in the list of enabled linters. A little bit of research shows that it seems thatpep8 has long been renamed topycodestyle, but pylama continues to acceptpep8 name for a while. Some time during pylama 7.7.1 and 8.4.1, the compatibility code that had allowed usingpep8 name in pylama has finally been removed and that breaks the test, as nowpycodestyle/pep8 linters are no longer running.

A quick fix for the test is to do something like:

diff --git a/pymode/lint.py b/pymode/lint.pyindex c530404..56208a6 100644--- a/pymode/lint.py+++ b/pymode/lint.py@@ -42,6 +42,10 @@ def code_check():             raise ValueError('g:pymode_lint_select should have a list type')         else:             select = env.var('g:pymode_lint_select')+        if 'pep8' in linters:+            ## maybe add user-visible deprecation warning here+            linters.remove('pep8')+            linters.append('pycodestyle')         options = parse_options(             linters=linters, force=1,             ignore=ignore,

this would make the test passes, but it would break theg:pymode_lint_options_pep8 config options, we should rename this option tog:pymode_lint_options_pycodestyle so there are a number of other places that needs to be fixed as well.

@diraoldiraol merged commit57384b9 intodevelopJul 3, 2023
@diraoldiraol deleted the dro/bump_dependencies branchJuly 3, 2023 01:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@diraol@lieryan

[8]ページ先頭

©2009-2025 Movatter.jp