Is auto-import supposed to work with 3rd party packages?#355

rodrigoscc started this conversation inGeneral

rodrigoscc

Mar 6, 2023

· 3 comments· 3 replies

Return to top

Discussion options

rodrigoscc
Mar 6, 2023

I have rope auto-import enabled and it works for built-in functions and classes. For instance, if I typeip_ad, theipaddress.ip_address function will be listed in the completion popup, and if I pick it, it will be automatically imported. However, if I typeMethodView, I don't seeflask.views.MethodView listed in the completion popup.

I made sure to activate the virtual environment with Flask installed before opening Neovim. So my question is, is this expected behavior or is there something wrong with my setup? Thanks.

Pylsp version: 1.7.1
Neovim: 0.8.3

You must be logged in to vote

Replies: 3 comments 3 replies

Comment options

rodrigoscc
Mar 6, 2023
Author

Alright, I figured it out. I forgot to update thepython_path rope setting.

For those interested, I added this to my project.ropeproject/config.py file:

def set_prefs(prefs):    prefs.add('python_path', '/Users/rodrigo/python-project/venv/lib/python3.9/site-packages/')

You must be logged in to vote

0 replies

Comment options

ccordoba12
Mar 6, 2023
Maintainer

@rstcruzo, thanks for mentioning a solution!

@bagel897, is there something we could about this on pylsp directly?

You must be logged in to vote

0 replies

Comment options

bagel897
Mar 6, 2023

Pylsp would need to run in the same virtual environment/be installed there. Otherwise you can pass the environment as a parameter to initialize the rope project in workspace.py

You must be logged in to vote

3 replies

Comment options

ccordoba12 Mar 6, 2023
Maintainer

Otherwise you can pass the environment as a parameter to initialize the rope project in workspace.py

Yeah, that's what I was thinking. Users could send a didChangeConfiguration to set their current interpreter for the Rope project we use for refactorings.

Comment options

bagel897 Mar 6, 2023

I would hold off on doing the didChangeConfiguration part untilthis issue and maybethis PR are resolved for speed/consistency reasons. Bit busy rn but shouldn't be too hard for someone to implement. First, I'd implement a general environment path for pylsp, possibly with PEP 582 support.