- Notifications
You must be signed in to change notification settings - Fork15
Adopt SPEC 0#537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Adopt SPEC 0#537
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedFeb 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #537 +/- ##==========================================+ Coverage 99.13% 99.29% +0.16%========================================== Files 93 93 Lines 21855 21855 Branches 4130 4130 ==========================================+ Hits 21667 21702 +35+ Misses 121 106 -15+ Partials 67 47 -20 |
Member
SultanOrazbayev commentedFeb 8, 2024
Sounds very reasonable. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More projects are endorsing/adopting SPEC 0, and I think we should too:
Even NumPy is moving towards SPEC 0 instead ofNEP 29.
Basically, we should feel okay moving forward and dropping old dependencies. This reduces our maintenance burden, and reduces maintenance burden for the whole ecosystem as SPEC 0 gets more widely accepted.
Changes:
@jim22k@SultanOrazbayev, since this is a policy change, I want your approval (even a thumbs up or rocket would suffice).