- Notifications
You must be signed in to change notification settings - Fork15
Addgb.MAX_SIZE, which isGrB_INDEX_MAX + 1#519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is the largest index, not the size of the domain of indices.For example, create the largest vector via `Vector(int, INDEX_MAX + 1)`.Also, note that the spec does not specify a value for `GrB_INDEX_MAX`,only that the implementation define it, so it may be backend-dependent.
codecovbot commentedNov 5, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #519 +/- ##==========================================- Coverage 99.69% 99.42% -0.27%========================================== Files 95 95 Lines 21884 21889 +5 Branches 4138 4139 +1 ==========================================- Hits 21818 21764 -54- Misses 40 78 +38- Partials 26 47 +21 |
michelp commentedNov 5, 2023
+1 for MAX_SIZE |
gb.INDEX_MAX, which isGrB_INDEX_MAXgb.MAX_SIZE, which isGrB_INDEX_MAX + 1michelp approved these changesNov 5, 2023
SultanOrazbayev approved these changesNov 6, 2023
Member
SultanOrazbayev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
MemberAuthor
eriknw commentedNov 6, 2023
Thanks, this is in! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INDEX_MAXmay be a nice global value to expose. The GraphBLAS spec doesn't have many of these globals.This is the largest index value, not the size of the domain of indices. For example, create the largest vector via
Vector(int, INDEX_MAX + 1). Also, note that the spec does not specify a value forGrB_INDEX_MAX, only that implementations define it, so it may be backend-dependent.Alternatively, we could instead define
MAX_SIZE, which would beGrB_INDEX_MAX + 1. I think this is much more natural to use; e.g.,Matrix(int, MAX_SIZE, MAX_SIZE). I don't think we need bothINDEX_MAXandMAX_SIZE.So, which to y'all prefer,
INDEX_MAXorMAX_SIZE? Feel free to suggest different names too.CC@michelp@jim22k@SultanOrazbayev