- Notifications
You must be signed in to change notification settings - Fork15
Add docstrings for using SS JIT, and make better#512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Also:- allow a SS JIT function to be registered under the same name with different input types- be extra-strict about input types for SS JIT- test numba JIT with select with udt
codecovbot commentedOct 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #512 +/- ##==========================================+ Coverage 92.86% 99.58% +6.71%========================================== Files 95 95 Lines 21106 21253 +147 Branches 3950 3987 +37 ==========================================+ Hits 19600 21164 +1564+ Misses 1342 65 -1277+ Partials 164 24 -140 |
michelp left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!
eriknw commentedOct 17, 2023
Thanks for taking a look@michelp! So I added codecov github comment in this PR. I don't know if I like it, but it's convenient to have an easy link to the coverage report. I made the message not quite as ugly as the default. Anyway, merging! I'll get overall approval from others before I do a release, which is coming soon. |
Also:
CC@michelp in case you want to look at the docstrings and signatures of our functions for using SuiteSparse:GraphBLAS JIT such as
gb.binary.ss.register_new--I think you're the most likely to show off something cool using the JIT ;)(also, let me know if you want help using the JIT locally).
I think we should cut a new release after this is merged.