Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding matrixorder=None to matrix classes#495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Transurgeon wants to merge3 commits intopython-graphblas:main
base:main
Choose a base branch
Loading
fromTransurgeon:adding-matrix-order

Conversation

Transurgeon
Copy link
Contributor

This PR adds an optional order argument to some matrix classes.
This is also the first task of issue#492

@coveralls
Copy link

Coverage Status

coverage: 99.719%. remained the same when pullinge1b00d6 on Transurgeon:adding-matrix-order into45ccf4b on python-graphblas:main.

@eriknw
Copy link
Member

Thanks for starting on this@Transurgeon!

I would recommend adding implementation too. Ideally, you should test and verify what you did is needed and works as expected as you addorder= arguments. Perhaps this also means addingmy_matrix.orientation attribute too, or just using the existingmy_matrix.ss.orientation attribute.

I would start withA.T.new(order="columnwise") and test that it works (add tests at the end ofgraphblas/tests/test_matrix.py).

Also,graphblas/core/utils.py:get_order will be helpful.

@Transurgeon
Copy link
ContributorAuthor

Transurgeon commentedSep 4, 2023
edited
Loading

Hello@eriknw , sorry for the delay on this, I have been finishing up some details for my GSoC project.
I tried to implement the orientation today, however, it is working as planned.
I have added the argument to bothMatrix.__new__ andTransposeMatrix.new(). I also calledget_order like you recommended, but the test that I have added doesn't seem to pass like I would expect.
I am starting to get lost in the layers of OOP abstraction.
More importantly, I am also having problems when debugging due to the error below, do you have any ideas on how to fix this?
image
P.S Is the expectation to addproperty.getter/setter for.ss.orientation? I thought that could be a solution but wasn't sure if it was what you wanted.

@eriknw
Copy link
Member

No worries :) I was also traveling and mostly AFK last week.

I will take a closer look at this PR. As for the error, it looks like you're running from within thepython-graphblas/graphblas directory (a builtin library is trying toimport select, and it's picking upgraphblas/select, which breaks). Try running frompython-graphblas directory.

@eriknw
Copy link
Member

Hey, sorry for letting this sit. I was traveling and on vacation the last two weeks. I should have time to give this attention later this week.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Transurgeon@coveralls@eriknw

[8]ページ先頭

©2009-2025 Movatter.jp