- Notifications
You must be signed in to change notification settings - Fork15
Adding matrixorder=None
to matrix classes#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedAug 26, 2023
Thanks for starting on this@Transurgeon! I would recommend adding implementation too. Ideally, you should test and verify what you did is needed and works as expected as you add I would start with Also, |
Transurgeon commentedSep 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello@eriknw , sorry for the delay on this, I have been finishing up some details for my GSoC project. |
No worries :) I was also traveling and mostly AFK last week. I will take a closer look at this PR. As for the error, it looks like you're running from within the |
Hey, sorry for letting this sit. I was traveling and on vacation the last two weeks. I should have time to give this attention later this week. |
This PR adds an optional order argument to some matrix classes.
This is also the first task of issue#492