Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

dropping support for python3.8#489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Transurgeon
Copy link
Contributor

Made changes to dependencies, pyproject.toml and CI workflows according to the instructions listed on thewiki.
However, I wasn't sure what to change for this particular instruction:
- Update minimum dependency versions to match what we test
Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

@eriknw
Copy link
Member

Thanks@Transurgeon! Welcome as a contributor 🎉

These changes look perfect to me to drop Python 3.8 👍

For reference, NEP 29 dropped Python 3.8 support in April this year, and SPEC 0 dropped it about a year ago:

However, I wasn't sure what to change for this particular instruction:

Update minimum dependency versions to match what we test

Aha, it means to update the minimum dependency versions inpyproject.tomlif removing Python 3.8 from CI means that we no longer test some versions of dependencies. We still test the same versions of dependencies as we did when we tested with Python 3.8, so no changes are necessary this time.

I will update the instructions on the wiki to mentionpyproject.toml, b/c I agree that wasn't clear. Thanks for the feedback.

Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

This means that if we want to, we can also change what versions of dependencies we support. This is completely optional, and I don't want to think about it right now, so let's do nothing :)

Merging!

SultanOrazbayev reacted with hooray emoji

@eriknweriknw merged commit9e1a390 intopython-graphblas:mainAug 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Transurgeon@eriknw

[8]ページ先頭

©2009-2025 Movatter.jp