Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update README.md#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eriknw merged 6 commits intopython-graphblas:mainfromSultanOrazbayev:patch-6
Mar 11, 2023
Merged

Conversation

@SultanOrazbayev
Copy link
Member

@SultanOrazbayevSultanOrazbayev commentedMar 10, 2023
edited
Loading

Adds Python version badges and description of optional dependencies inREADME.md.

Partially addresses#402

Adds Python version badges
@coveralls
Copy link

coveralls commentedMar 10, 2023
edited
Loading

Coverage Status

Coverage: 99.494% (+0.07%) from 99.425% when pulling7d9452b on SultanOrazbayev:patch-6 into673650d on python-graphblas:main.

optional dependencies copied from docs
@eriknw
Copy link
Member

LGTM, thanks@SultanOrazbayev.

We can close#402 if you add yourself to Maintainers (if you'd like, and up to you if you want to include your email). I like the discussion around "who is a maintainer" from a recent NetworkX meeting where the prevailing opinion was that "maintainer" means being an active maintainer, which means actively engaging in discussions, PRs, and/or creating PRs. You definitely qualify :) . Plus, you're already a member in the github org.

I think we should also include"Python-graphblas Contributors" in the authors section of pyproject.toml.

SultanOrazbayev reacted with rocket emoji

@SultanOrazbayev
Copy link
MemberAuthor

SultanOrazbayev commentedMar 11, 2023
edited
Loading

Thank you, Erik!

re: contributor section
I couldn't find the name for@ParticularMiner , and then thought maybe it's OK to include just GitHub handles. That didn't work out. :/

Removed `contributors` (not a valid key for project description it seems):```contributors = [    {GitHub_handle = "eriknw"},    {GitHub_handle = "jim22k"},    {GitHub_handle = "ParticularMiner"},    {GitHub_handle = "SultanOrazbayev"},    {GitHub_handle = "seibert"},]```
@eriknweriknw merged commita0c152c intopython-graphblas:mainMar 11, 2023
@eriknw
Copy link
Member

This is in, thanks@SultanOrazbayev (and welcome as a more-officially recognized maintainer)!

And, yeah, no need to include all the names or github handles of all the contributors underauthors. The git log and github has a record of that, and the authorship shows up properly in Zenodo.

It's sad that ParticularMiner seems to have disappeared 8 months ago. I hope he's okay and simply too busy having fun ;)

SultanOrazbayev reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SultanOrazbayev@coveralls@eriknw

[8]ページ先頭

©2009-2025 Movatter.jp