- Notifications
You must be signed in to change notification settings - Fork15
Remove expired deprecation of using scipy matrix#393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedFeb 21, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
eriknw commentedFeb 21, 2023
Oh, interesting test failures (randomized testing ftw?!). This is using It looks like
So, we'll need to update tests to ignore these on Windows. I'm not sure what's up with the error with |
eriknw commentedFeb 21, 2023
Heh, so we may have more places where we use |
| blocklist["FC64"].update({"asin","asinh"}) | ||
| blocklist["FC32"]= {"asin","asinh"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know if we strictly need to excludeasinh given the input arguments we use, butasinh was called out in the documentation for not working.
eriknw commentedFeb 21, 2023
I'm going to go ahead and merge this since it contains a fix, and I don't think the removed deprecations are particularly significant. |
coveralls commentedAug 10, 2025
Changes unknown |
Note that we now maintain a list of active deprecations on our wiki:
https://github.com/python-graphblas/python-graphblas/wiki/Active-deprecations