Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove expired deprecation of using scipy matrix#393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eriknw merged 3 commits intopython-graphblas:mainfromeriknw:remove_scipy_matrix
Feb 21, 2023

Conversation

@eriknw
Copy link
Member

Note that we now maintain a list of active deprecations on our wiki:

https://github.com/python-graphblas/python-graphblas/wiki/Active-deprecations

@eriknweriknw added the deprecationSomething is being removed labelFeb 21, 2023
@coveralls
Copy link

coveralls commentedFeb 21, 2023
edited
Loading

Coverage Status

Coverage: 99.424% (-0.08%) from 99.505% when pulling9c9df06 on eriknw:remove_scipy_matrix intob7e9485 on python-graphblas:main.

@eriknw
Copy link
MemberAuthor

Oh, interesting test failures (randomized testing ftw?!). This is usingpython-suitesparse-graphblas from upstream, which supports complex on Windows.

It looks likeasin(4 + 0j) gives the wrong results on Windows in SuiteSparse:GraphBLAS. This is a known limitation. From SuiteSparse:GraphBLAS documentation:

  1. On Windows, the casin, casinf, casinh, and casinhf functions provided by Microsoft do not return the correct imaginary part. As a result, GxB_ASIN_FC32, GxB_ASIN_FC64 GxB_ASINH_FC32, and GxB_ASINH_FC64 do not work properly on Windows. This affects the GrB/asin, GrB/acsc, GrB/asinh, and GrB/acsch, functions in the MATLAB interface. See the MATLAB tests bypassed in gbtest76.m for details, in the GraphBLAS/GraphBLAS/test folder.

So, we'll need to update tests to ignore these on Windows.

I'm not sure what's up with the error withldexp. Need to print more info.

@eriknw
Copy link
MemberAuthor

Heh, so we may have more places where we useif not _supports_complex instead ofif is_win. If so, we'll fine them eventually.

Comment on lines +71 to +72
blocklist["FC64"].update({"asin","asinh"})
blocklist["FC32"]= {"asin","asinh"}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know if we strictly need to excludeasinh given the input arguments we use, butasinh was called out in the documentation for not working.

@eriknw
Copy link
MemberAuthor

I'm going to go ahead and merge this since it contains a fix, and I don't think the removed deprecations are particularly significant.

@eriknweriknw merged commit096d374 intopython-graphblas:mainFeb 21, 2023
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling0213c4b on eriknw:remove_scipy_matrix
into ** on python-graphblas:main**.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

deprecationSomething is being removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eriknw@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp