- Notifications
You must be signed in to change notification settings - Fork5
Implementgoogle_matrix and binary operators#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eriknw commentedMay 1, 2023
@jim22k, |
Uh oh!
There was an error while loading.Please reload this page.
jim22k commentedMay 1, 2023
Other than my comment above, this all looks good to me. |
eriknw commentedMay 2, 2023
Thanks for reviewing! Thoughts on the failing test? |
jim22k commentedMay 2, 2023
I think the line: The point of that test is to check that Can you make that change in NetworkX and see if the tests pass? If so, please add that change toyour NetworkX PR. Thanks! |
eriknw commentedMay 2, 2023
This doesn't work, b/c we convert networkx graphs (we always call e.g. |
jim22k commentedMay 2, 2023
Oops. Try this instead: # Only test if not performing auto convert testing of backend implementationsifos.environ.get("NETWORKX_GRAPH_CONVERT",None)isNone: The goal is to only test this if wearen't doing auto convert testing. |
This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
eriknw commentedMay 3, 2023
Merging. The test failure is understood--we are waiting on NetworkX PR to be merged. |
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
These aren't super-optimized or super-clean, but are hopefully "good enough" for a while.