Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implementgoogle_matrix and binary operators#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eriknw merged 4 commits intopython-graphblas:mainfromeriknw:google_matrix
May 3, 2023

Conversation

@eriknw
Copy link
Member

These aren't super-optimized or super-clean, but are hopefully "good enough" for a while.

@eriknw
Copy link
MemberAuthor

@jim22k,test_intersection is raising, and it looks like code you added. Can you help? Note that I implementedintersection in this PR.

@jim22k
Copy link
Member

Other than my comment above, this all looks good to me.

@eriknw
Copy link
MemberAuthor

Other than my comment above, this all looks good to me.

Thanks for reviewing! Thoughts on the failing test?

@jim22k
Copy link
Member

Thoughts on the failing test?

I think the line:
if os.environ.get("NETWORKX_GRAPH_CONVERT", None) != "nx-loopback":
should instead be:
if os.environ.get("NETWORKX_GRAPH_CONVERT", None) is not None:

The point of that test is to check thatnx._dispatch raises aTypeError when differently typed Graph objects are passed in. But we don't need to test that during auto dispatching tests.

Can you make that change in NetworkX and see if the tests pass? If so, please add that change toyour NetworkX PR. Thanks!

@eriknw
Copy link
MemberAuthor

if os.environ.get("NETWORKX_GRAPH_CONVERT", None) is not None:

This doesn't work, b/c we convert networkx graphs (we always call e.g.to_graph). Should it instead be== "nx-loopback":? I still don't quite follow what's going on. Also, I think this ought to be broken out into its own test.

@jim22k
Copy link
Member

Oops. Try this instead:

# Only test if not performing auto convert testing of backend implementationsifos.environ.get("NETWORKX_GRAPH_CONVERT",None)isNone:

The goal is to only test this if wearen't doing auto convert testing.

eriknw added a commit to eriknw/networkx that referenced this pull requestMay 2, 2023
@eriknw
Copy link
MemberAuthor

Merging. The test failure is understood--we are waiting on NetworkX PR to be merged.

@eriknweriknw merged commit80ba68b intopython-graphblas:mainMay 3, 2023
MridulS pushed a commit to networkx/networkx that referenced this pull requestMay 13, 2023
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull requestOct 13, 2023
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull requestOct 23, 2023
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull requestApr 22, 2024
* Handle weights as `distance=` in testing dispatch* fix `test_intersection`This change was suggested here:python-graphblas/graphblas-algorithms#62 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jim22kjim22kjim22k left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eriknw@jim22k

[8]ページ先頭

©2009-2025 Movatter.jp