- Notifications
You must be signed in to change notification settings - Fork673
Adding newProjectHook attributes:#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* `build_events`* `enable_ssl_verification`See the two links below:*https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/projects.md#add-project-hook*pyapi-gitlab/pyapi-gitlab#173
two separate strings on different lines into one string.seepython-gitlab#89will try to rebase pull request to include this.
lol build failed b/c: hrmm |
| @@ -851,7 +851,8 @@ class ProjectHook(GitlabObject): | |||
| requiredUrlAttrs = ['project_id'] | |||
| requiredCreateAttrs = ['url'] | |||
| optionalCreateAttrs = ['push_events', 'issues_events', | |||
| 'merge_requests_events', 'tag_push_events'] | |||
| 'merge_requests_events', 'tag_push_events', | |||
| 'build_events', 'enable_ssl_verification'] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't see build_events in the doc. I see note_events though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
two separate strings on different lines into one stringseepython-gitlab#89will try to rebase pull request to include this
hhhhhhhhh ok, I'll reword that commit again. Never knew there were such stringent restrictions on commit messages. |
I probably should ignore the commit message check, I agree it's a bit annoying. |
Adding new `ProjectHook` attributes:
Thank you! |
build_eventsenable_ssl_verificationSee the two links below: