- Notifications
You must be signed in to change notification settings - Fork673
Fix Pickle support: dump() after load() fails#826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@bourgesl Thanks for your contribution. Could you please follow our conventional changelog and squash your commits into one? |
@bourgesl I've created a new branch with your commit in it. Thanks again! |
Thanks for your help, I did not have time during the week end to squash commits, sorry |
No problem. It's merged now :) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one-liner fix to pickle support: pickle.dump() fails after pickle.load()
Reason:
Former self._module call invokes
set_attr()that stores '_module' attribute inself.__dict__["_updated_attrs"]["_module"]that is not its correct place:self.__dict__["_module"]as expected by getstate()