Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Resolve #822, add mr rebase#823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 1 commit intopython-gitlab:masterfromjeroen92:rebase-mr
Jul 21, 2019

Conversation

jeroen92
Copy link
Contributor

Hi all. This MR adds the rebase method for an MR. Also adds an example in the documentation.

@max-wittig
Copy link
Member

Thanks for this cool contribution. Could you also add tests to it? (I'm sorry that they fail in the CI)

@jeroen92
Copy link
ContributorAuthor

I've added the rebase to the e2e test. I'm a bit hesitant to add checking themr.rebase_in_progress as it would introduce a race condition. When the rebase is complete therebase_in_progress property will be reset back toFalse.

@max-wittig
Copy link
Member

Okay then we leave them out. I will run the tests manually tomorrow and merge, if they succeed.

jeroen92 reacted with thumbs up emoji

@max-wittigmax-wittig merged commitb9877b4 intopython-gitlab:masterJul 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jeroen92@max-wittig
[8]ページ先頭
©2009-2025 Movatter.jp