NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Custom cli actions fix#760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 2 commits intopython-gitlab:masterfromkkoralsky:custom_cli_actions_fix

May 10, 2019

Merged

Custom cli actions fix#760

max-wittig merged 2 commits intopython-gitlab:masterfromkkoralsky:custom_cli_actions_fix

May 10, 2019

Conversation

Copy link

Contributor

kkoralsky commentedApr 24, 2019

run into 2 cli custom actions related issues while wokring on#759

*Manager custom actions (in_obj=False) ask formanaged object id for example:
- $ gitlab project-key enable --help or
- $ gitlab runner all --help
*Manager custom actions (in_obj=False) dont get -/_ method name replaced

kkoralsky added2 commits

April 24, 2019 11:49

dont ask for id attr if this is *Manager originating custom action

adb6305

fix -/_ replacament for *Manager custom actions

6158fd2

Copy link

Member

max-wittig commentedApr 24, 2019

Thanks for the contribution. What do you mean withask for managed object id for example:. I've tested your changes against master and don't see any difference in CLI output.

Copy link

ContributorAuthor

kkoralsky commentedApr 25, 2019

Basically for the first example action (gitlab project-key enable), cli would require --id and --key-id mandatory flags,

(ansdev3) koral@x270 ~/w/python-gitlab ±master⚡ » gitlab project-key enable --helpusage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]                                 --id ID --key-id KEY_IDoptional arguments:  -h, --help            show this help message and exit  --project-id PROJECT_ID  --sudo SUDO  --id ID  --key-id KEY_ID

I doubled checked if I did push all changes here is output on my branch:

(ansdev3) koral@x270 ~/w/python-gitlab ±custom_cli_actions_fix⚡ » gitlab project-key enable --helpusage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]                                 --key-id KEY_IDoptional arguments:  -h, --help            show this help message and exit  --project-id PROJECT_ID  --sudo SUDO  --key-id KEY_ID