- Notifications
You must be signed in to change notification settings - Fork673
Fix all kwarg behaviour#701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
`all` kwarg is used to manage GitlabList generator behaviour.However, as it is not poped from kwargs, it is sent to Gitlab API.Some endpoints such as [the project commits](https://docs.gitlab.com/ee/api/commits.html#list-repository-commits) one,support a `all` attribute.This means a call like `project.commits.list(all=True, ref_name='master')`won't return all the master commits as one might expect but all therepository's commits.To prevent confusion, the same kwarg shouldn't be used for 2 distinctpurposes.Moreover according to [the documentation](https://python-gitlab.readthedocs.io/en/stable/gl_objects/commits.html#examples),the `all` project commits API endpoint attribute doesn't seem supported.
max-wittig commentedFeb 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Makes sense. To use the |
Uh oh!
There was an error while loading.Please reload this page.
@gpocentek We may need to update the documentation that |
@max-wittig yes, we need to add that info in the release notes |
@gpocentek Could you disable the travis requirement temporary to merge this? |
all
kwarg is used to manage GitlabList generator behaviour.However, as it is not pop'ed from kwargs, it is sent to Gitlab API.
Some endpoints such asthe project commits one,
support a
all
attribute.This means a call like
project.commits.list(all=True, ref_name='master')
won't return all the master commits as one might expect but all the
repository's commits.
To prevent confusion, the same kwarg shouldn't be used for 2 distinct
purposes.
Moreover according tothe documentation,
the
all
project commits API endpoint attribute doesn't seem supported.