Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Added approve method for Mergerequests#685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 2 commits intopython-gitlab:masterfromJoustie:master
Jan 21, 2019

Conversation

Joustie
Copy link
Contributor

Offical GitLab API supports approval for GitLab EE

Copy link
Contributor

@gpocentekgpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, the code looks good!

Could you have a look at the pep8 failures (missing blank lines).

GitLab EE also provides anunapprove method that could be added here. But it's OK if you don't do it :)

@Joustie
Copy link
ContributorAuthor

I have added the unapprove method and I have put the parameters on one line, added default value for sha. I could not find the pep8 errors about double missing blank lines? (I ran tox locally against my branch).

@max-wittig
Copy link
Member

@gpocentek Travis is not reporting back and I don't see the build in the UI. Do you have any way to restart it?

@JoustieJoustie reopened thisJan 19, 2019
@Joustie
Copy link
ContributorAuthor

I am not very familiar with travis, I have closed and reopened the pull request. That should trigger another build?

@JoustieJoustie reopened thisJan 19, 2019
@max-wittig
Copy link
Member

A force push would trigger another build. But I think@gpocentek should be able to restart it manually.

@gpocentek
Copy link
Contributor

I can't see the build on travis.

@Joustie Do you mind doing a rebase and a push --force? Thanks!

@JoustieJoustieforce-pushed themaster branch 3 times, most recently from2d1a3ac to757a2d8CompareJanuary 19, 2019 20:13
@JoustieJoustie reopened thisJan 19, 2019
@Joustie
Copy link
ContributorAuthor

@gpocentek I have made sure the travis builds succeed for my fork, and rebased and pushed --force but still the checks are not updated? Maybe try a brandnew PR?

Offical GitLab API supports this for GitLab EE
@max-wittig
Copy link
Member

max-wittig commentedJan 20, 2019
edited
Loading

@Joustie I'm sorry that travis is misbehaving. I think we should merge it. Tests pass locally for me.

@Joustie Could you do a rebase and then@gpocentek could merge it. (not sure, if I could as CI is failing)

@gpocentek
Copy link
Contributor

@Joustie the changes look good and we'll merge without travis, but there are merge conflicts that need to be resolved first. Could you have a look at that?

Thanks!

@max-wittigmax-wittig merged commit641b80a intopython-gitlab:masterJan 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpocentekgpocentekgpocentek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@Joustie@max-wittig@gpocentek

[8]ページ先頭

©2009-2025 Movatter.jp