- Notifications
You must be signed in to change notification settings - Fork673
fix(docker): use docker image with current sources#605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Dockerfile Outdated
| WORKDIR /opt/python-gitlab | ||
| COPY --from=build /opt/python-gitlab/dist dist/ | ||
| RUN pip install $(find dist -name *.whl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could also delete the wheel here, and build the docker image with--squash, to save a tiny bit of extra space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
--squash still seems to be experimental, but otherwise good idea!
Dockerfile Outdated
| @@ -0,0 +1,15 @@ | |||
| FROM python:alpine AS build | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we pin to a Python version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might be better. Maybe 3.8 will break something. I don't think so, but best practice.
README.rst Outdated
| How to use | ||
| ---------- | ||
| ``docker run -it --rm -e GITLAB_PRIVATE_TOKEN=<your token> =/python-gitlab.cfg python-gitlab <command> ...`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ghost =/python-gitlab.cfg ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I copied that from contrib/docker/README.rst and just glanced over it. Nice find.
@gpocentek Feel free to merge, if you approve 😃 |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#602