Sep 29, 2018 · Sep 29, 2018 · Oct 3, 2018 · Oct 3, 2018
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
    _update_attrs = (('access_level', ), ('expires_at', ))


 class GroupMemberAll(RESTObject):
    pass


 class GroupMemberAllManager(ListMixin, RESTManager):
    _path = '/groups/%(group_id)s/members/all'
    _obj_cls = GroupMemberAll
    _from_parent_attrs = {'group_id': 'id'}


 class GroupMergeRequest(RESTObject):
    pass

        ('epics', 'GroupEpicManager'),
        ('issues', 'GroupIssueManager'),
        ('members', 'GroupMemberManager'),
        ('membersAll', 'GroupMemberAllManager'),
        ('mergerequests', 'GroupMergeRequestManager'),
        ('milestones', 'GroupMilestoneManager'),
        ('notificationsettings', 'GroupNotificationSettingsManager'),
Original file line number	Diff line number	Diff line change
Expand Up		@@ -706,6 +706,16 @@ class GroupMemberManager(CRUDMixin, RESTManager):
		_update_attrs = (('access_level', ), ('expires_at', ))


		class GroupMemberAll(RESTObject):
		pass


		class GroupMemberAllManager(ListMixin, RESTManager):
Copy link Contributor gpocentekOct 3, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I understand your goal here, but I think it would make more sense to add an`all()` method to the`GroupMemberManager` class. The`RunnerManager` class has the same logic. From a REST point of view`all` is an action applied to the resource at path`/groups/:id:/members` (GroupMember). Does that make sense? Copy link ContributorAuthor hans-dOct 3, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Makes sense, hadn't seen that variation yet. Will try to change it like that soonish
		_path = '/groups/%(group_id)s/members/all'
		_obj_cls = GroupMemberAll
		_from_parent_attrs = {'group_id': 'id'}


		class GroupMergeRequest(RESTObject):
		pass

Expand DownExpand Up		@@ -850,6 +860,7 @@ class Group(SaveMixin, ObjectDeleteMixin, RESTObject):
		('epics', 'GroupEpicManager'),
		('issues', 'GroupIssueManager'),
		('members', 'GroupMemberManager'),
		('membersAll', 'GroupMemberAllManager'),
		('mergerequests', 'GroupMergeRequestManager'),
		('milestones', 'GroupMilestoneManager'),
		('notificationsettings', 'GroupNotificationSettingsManager'),
Expand Down