NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Add support for searching groups#55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dserodio wants to merge2 commits intopython-gitlab:masterfromdserodio:search_groups

Closed

Add support for searching groups#55

dserodio wants to merge2 commits intopython-gitlab:masterfromdserodio:search_groups

Conversation

Copy link

dserodio commentedFeb 13, 2015

It can probably be improved, but works for my needs

Daniel Serodio added2 commits

February 13, 2015 15:07

Add support for searching groups

cc33f07

Improve docstring for search_groups

5fce4bf

Copy link

ghost commentedOct 17, 2015

I agree with you Gauvain. It would be nice if these kind of 'search' functions are implemented directly in the classes (like Group or project).

What do you think about this:

A special class to do queries (we will have the possibility to choose between):

id=None, to list everything
or GitlabQuery(), to add some rules

    projects = git.Project(GitlabQuery(name="projectname"))    projects = git.Project(GitlabQuery(is_admin=True))    groups = git.Group(GitlabQuery(name="groupname"))

gpocentek pushed a commit that referenced this pull request

Jan 9, 2016

Add support for groups search

5513d0f

Factorize the code to avoid duplication with the ProjectManager class.Implement unit tests for the group search.Original patchh from Daniel Serodio (PR#55).