- Notifications
You must be signed in to change notification settings - Fork673
add per_page config option#505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| m_open.return_value = fd | ||
| config.GitlabConfigParser('one') | ||
| config.GitlabConfigParser('one') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this duplicated line is useful :) Could you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added this to test the change line#97.
Without the fd.seek(0), all calls to config.GitlabConfigParser fail except the 1st one:
# fd.tell() = 0config.GitlabConfigParser('one')# reads fd# fd.tell() = end of fileconfig.GitlabConfigParser('one')# reads nothing because fd is at end of file, so it fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, thanks for the explanation.
LGTM, can you just drop the extra line (see comment). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll update the documentation before the merge.
| m_open.return_value = fd | ||
| config.GitlabConfigParser('one') | ||
| config.GitlabConfigParser('one') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added this to test the change line#97.
Without the fd.seek(0), all calls to config.GitlabConfigParser fail except the 1st one:
# fd.tell() = 0config.GitlabConfigParser('one')# reads fd# fd.tell() = end of fileconfig.GitlabConfigParser('one')# reads nothing because fd is at end of file, so it fail
Close#503 .